Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not require scroll-to-bottom for SIWE or Signatures with simulations before enabling Confirm footer #26887

Merged
merged 20 commits into from
Sep 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
66a04dd
refactor: rn isScrollToBottomNeeded-> isScrollToBottomFulfilled
digiwand Sep 4, 2024
aace264
refactor: mv conditional to isConfirmDisabled
digiwand Sep 4, 2024
2c59ab8
fix: rn isScrollToBottomFulfilled -> isScrollToBottomUnfulfilled
digiwand Sep 4, 2024
5f68231
refactor: update isSIWESignatureRequest to allow Confirmation types t…
digiwand Sep 4, 2024
5491bc7
feat: add ConfirmFooter scroll tests
digiwand Sep 4, 2024
00a2998
refactor: rn isScrollToBottomUncompleted unfulfilled -> uncomplete
digiwand Sep 4, 2024
fc6377b
refactor: reverse isScrollToBottomUncompleted -> isScrollToBottomComp…
digiwand Sep 4, 2024
c159bf0
fix: ConfirmFooter scroll tests
digiwand Sep 4, 2024
2c8673a
feat: ConfirmFooter do not require scroll for SIWE
digiwand Sep 4, 2024
9f30b98
refactor: isPermitSignatureRequest can accept any Confirmation to tes…
digiwand Sep 4, 2024
dcf9a9c
feat: do not require scroll if Permit Simulation is shown
digiwand Sep 4, 2024
64cbdd4
fix: confirm snapshots
digiwand Sep 4, 2024
7ceebad
fix: restore async ConfirmPage test
digiwand Sep 4, 2024
16449a8
Merge branch 'develop' into feat-update-confirm-footer-requirements
digiwand Sep 5, 2024
f0db665
fix: update ConfirmPage & Footer tests following merge changes
digiwand Sep 5, 2024
fb116e5
fix: ScrollToBottom test
digiwand Sep 5, 2024
e8ecf66
Merge branch 'develop' into feat-update-confirm-footer-requirements
digiwand Sep 5, 2024
b3d2f3c
Merge branch 'develop' into feat-update-confirm-footer-requirements
digiwand Sep 5, 2024
534c3c9
Merge branch 'develop' into feat-update-confirm-footer-requirements
digiwand Sep 5, 2024
3d47a03
fix: isScrollToBottomNeeded -> isScrollToBottomCompleted
digiwand Sep 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: restore async ConfirmPage test
digiwand committed Sep 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 7ceebad266725a20bdb484fd6c6c4efdf04e11ad
2 changes: 1 addition & 1 deletion ui/pages/confirmations/confirm/confirm.test.tsx
Original file line number Diff line number Diff line change
@@ -107,7 +107,7 @@ describe('Confirm', () => {
expect(container).toMatchSnapshot();
});

it('should match snapshot for signature - typed sign - V4', () => {
it('should match snapshot for signature - typed sign - V4', async () => {
const mockStateTypedSign = getMockTypedSignConfirmState();
const mockStore = configureMockStore(middleware)(mockStateTypedSign);
const { container } = renderWithConfirmContextProvider(