Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add approval static simulation #26514

Merged
merged 8 commits into from
Aug 21, 2024
Merged

feat: Add approval static simulation #26514

merged 8 commits into from
Aug 21, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Aug 19, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3010

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Aug 19, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Aug 19, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners August 19, 2024 15:35
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [fed69e0]
Page Load Metrics (94 ± 13 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641861223215
domContentLoaded42154902814
load49155942613
domInteractive108436199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 8.61 KiB (0.12%)
  • common: 447 Bytes (0.01%)

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.97%. Comparing base (dc347b2) to head (fed69e0).

Files Patch % Lines
...ations/components/confirm/info/approve/approve.tsx 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           pnf/2936   #26514   +/-   ##
=========================================
  Coverage     69.97%   69.97%           
=========================================
  Files          1407     1408    +1     
  Lines         49023    49038   +15     
  Branches      13705    13707    +2     
=========================================
+ Hits          34299    34311   +12     
- Misses        14724    14727    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from pnf/2936 to develop August 21, 2024 13:20
Copy link

@pedronfigueiredo pedronfigueiredo merged commit 1a5003d into develop Aug 21, 2024
77 of 78 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3010 branch August 21, 2024 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1c1f0c1]
Page Load Metrics (81 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint731771082512
domContentLoaded5210875178
load5911881168
domInteractive115929115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 3.6 KiB (0.05%)
  • common: 161 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
@digiwand digiwand added release-12.3.0 Issue or pull request that will be included in release 12.3.0 release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants