-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement client side malicious network request detection #25839
Merged
+170
−252
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
56d4283
wip: mvp to show blocking c2 domains
70467d7
wip: mvp to show blocking c2 domains
f2396ef
wip: all logic is not abstracted within the phishing controller withi…
7178989
feat: succesfully redirects users to the phishing page if the domain …
3beabd1
feat: added a reason to meta metrics for when we block a website
25680ea
wip
AugmentedMode 24075b9
wip
AugmentedMode 0f3f5ae
chore: merge main into feature branch
AugmentedMode 4eeac70
chore: fix test that seems to be already broken for now
AugmentedMode c835b62
wip: send url instead of hostname to check phishing controller
AugmentedMode ac4534d
chore: remove local phishing controller and pull in phishing controll…
AugmentedMode 4e78351
chore: fix merge conflicts
AugmentedMode 777fbb0
chore: support new test function where we have to send the url instea…
AugmentedMode abd8869
Update LavaMoat policies
metamaskbot 7e8894d
chore: Update privacy-snapshot.json with new API endpoint for client-…
AugmentedMode 20d1b40
Merge branch 'feat/client-side-detection' of https://github.com/MetaM…
AugmentedMode c41895d
chore: fix failing tests
AugmentedMode 7465082
chore: add tests to cover c2 domian detection
AugmentedMode 10da980
chore: yarn dedupe
AugmentedMode f5ed2ab
Update LavaMoat policies
metamaskbot ddda6f7
chore: fix privacy snapshot url for client-side-detection.api.cx.meta…
AugmentedMode bab80a3
chore: remove all references to phishfort
AugmentedMode dc7f4b5
fix: mock timestamp query
AugmentedMode 6fbc046
chore: bring back correct phishing controller version
AugmentedMode bb4b2f4
chore: update phishing controller version to 12.0.1
AugmentedMode a0a27ed
chore: add tests for ipfs blocking
AugmentedMode 18f0ca2
Merge branch 'develop' into feat/client-side-detection
AugmentedMode 3d4bcd9
chore: add tests for ipfs blocking
AugmentedMode 08c9f3d
Merge branch 'feat/client-side-detection' of https://github.com/MetaM…
AugmentedMode b47587e
chore: fix ipfs tests
AugmentedMode 0b5e4ee
chore: add more ipfs tests
AugmentedMode fc58e1f
chore: fix pr comments
AugmentedMode 0f0794a
Merge branch 'develop' into feat/client-side-detection
AugmentedMode f5fde7b
chore: fix pr comments
AugmentedMode 1ec468c
Merge branch 'feat/client-side-detection' of https://github.com/MetaM…
AugmentedMode cebf9f0
Merge branch 'develop' into feat/client-side-detection
AugmentedMode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
chore: fix test that seems to be already broken for now
commit 4eeac701419d01e3f9d5d2e530938b4e6468ef4b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'### Severity', | ||
]; | ||
// Titles of PR template | ||
const prTemplateTitles = [ | ||
'## **Description**', | ||
'## **Related issues**', | ||
'## **Manual testing steps**', | ||
'## **Screenshots/Recordings**', | ||
'## **Pre-merge author checklist**', | ||
'## **Pre-merge reviewer checklist**', | ||
Check failure on line 47 in .github/scripts/shared/template.ts
|
||
]; | ||
export const templates = new Map<TemplateType, Template>([ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This is caused by the major version difference in the
base-controller
versions used inphishing-controller
(v6) vs. extension (v5).The only reason we're not seeing the same error in
metamask-controller.js
is because the file hasn't been converted to TypeScript.