Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users of Metamask swap of high slippage #9944

Closed
cometothecaml opened this issue Nov 25, 2020 · 2 comments
Closed

Warn users of Metamask swap of high slippage #9944

cometothecaml opened this issue Nov 25, 2020 · 2 comments

Comments

@cometothecaml
Copy link

Describe the bug
Metamask swap seems to not warn users of high slippage. For example, this user swapped $600 in LP tokens for pretty much 0 WETH. A basic sanity check (like making sure the slip is not 99% or not allowing swaps of UNI V2 tokens) would have saved the funds.

Reddit post:
https://www.reddit.com/r/ethereum/comments/k0egph/swapped_uni_eth_lp_to_eth_on_metamask_but_where/

Etherscan TX:
https://etherscan.io/tx/0xf64e0d7a8aad3d69b64c7ba37304429d6f0a7dfd6fff66af47b94b46b88f29e8

Steps to reproduce (REQUIRED)
1.) Try to swap the UNI-WETH liquidity token to WETH

Expected behavior:
The user should have been alerted to the huge slip/price impact his TX would have caused. Looking at the screenshot the user sent, there wasn't a warning about price impact. Also, preventing users from swapping liquidity tokens would also help.

@danjm
Copy link
Contributor

danjm commented Nov 26, 2020

Thanks for the report! There is a PR in review that addresses this #9899

@Gudahtt
Copy link
Member

Gudahtt commented Jan 14, 2021

This was addressed in #9899

@Gudahtt Gudahtt closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants