Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In certain instances translation text breaks dropdown items #7331

Closed
rickycodes opened this issue Oct 30, 2019 · 2 comments
Closed

In certain instances translation text breaks dropdown items #7331

rickycodes opened this issue Oct 30, 2019 · 2 comments
Assignees
@rickycodes
Labels
good first issue Good for newcomers

Comments

@rickycodes
Copy link
Contributor

account menu is a fixed width and will push text below the corresponding icon in certain translation scenarios.

Steps to reproduce the behavior:

  1. Go to settings/general
  2. Change the language selection to "Français"
  3. Observe the below (what's in the screenshot)

account menu should have a min width (vs fixed) to accommodate longer texts in other languages

image
@rickycodes rickycodes self-assigned this Oct 30, 2019
@hjlee9182
Copy link
Contributor

hjlee9182 commented Nov 1, 2019 •
edited
Loading

You want to make one line ? (dynamic width?)

  1. one line
  2. one line ( Connector un portedeuille hard....)
    What is you wanted?

@rickycodes rickycodes added the good first issue Good for newcomers label Nov 5, 2019
@hjlee9182 hjlee9182 mentioned this issue Nov 5, 2019
Merged
@Gudahtt
Copy link
Member

Gudahtt commented Nov 5, 2019

This has been fixed in #7354

@Gudahtt Gudahtt closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickycodes rickycodes

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rickycodes @Gudahtt @hjlee9182