Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header is taller if custom RPC is selected #6442

Closed
wbt opened this issue Apr 10, 2019 · 2 comments
Closed

Header is taller if custom RPC is selected #6442

wbt opened this issue Apr 10, 2019 · 2 comments
Assignees
Labels
area-UI Relating to the user interface. type-bug

Comments

@wbt
Copy link
Contributor

wbt commented Apr 10, 2019

Describe the bug
The header portion of the MetaMask UI is slightly taller when connecting to a custom RPC, throwing off other vertical alignment around what might be visible with vs. without scrolling.

To Reproduce
Steps to reproduce the behavior:

  1. Open a browser with MetaMask and log in.
  2. Connect to a custom RPC network.
  3. Go to Settings -> About Us (a bit harder to find due to Issue Clicking "Info & Help" doesn't produce expected results #6441)
  4. Observe how "Visit our Support Center" appears partially cut off, not part of what the user is intended to be able to see/interact with until after additional scroll action.
    image
  5. Connect to the Main Ethereum Network
  6. Observe how less of the text is cut off:
    image

Expected behavior
Custom RPC settings permit a custom icon/color picker, and the default has the same height as the networks that come pre-programmed in.

Browser details (please complete the following information):

  • OS: Windows 10 Pro
  • Browser: Chrome 72.0.3626.121 (Official Build) (64-bit)
  • MetaMask Version: 6.3.1
@bdresser bdresser added area-UI Relating to the user interface. type-bug labels Apr 10, 2019
@chikeichan chikeichan self-assigned this Apr 11, 2019
@danjm danjm added this to the Sprint: 4/15 - 4/25 milestone Apr 14, 2019
@danjm danjm closed this as completed Apr 19, 2019
@wbt
Copy link
Contributor Author

wbt commented Apr 19, 2019

Is there a PR which fixes this, regarding the closure?

@bdresser
Copy link
Contributor

#6468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-bug
Projects
None yet
Development

No branches or pull requests

5 participants
@wbt @bdresser @danjm @chikeichan and others