Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_signTypedData not sending result to browser #4993

Closed
1blockologist opened this issue Aug 8, 2018 · 3 comments
Closed

eth_signTypedData not sending result to browser #4993

1blockologist opened this issue Aug 8, 2018 · 3 comments

Comments

@1blockologist
Copy link

www.pareto.network not accessible with Metamask with today's version

The console log mentions that "This experimental version of eth_signTypedData will be deprecated", is there a new function we should be using, or is it the same method name with different logic inside? Since this message is still there and not actually deprecated yet, then this is a bug that needs a hot fix

anything I can help with?

@1blockologist
Copy link
Author

I feel like a unit test would have noticed this

@evansjohnson
Copy link

I am also having this issue. For me, just before the MM UI updates to reflect a spinner that never resolves, the message "cannot read property EIP712Domain of undefined" shows on the UI.

I found the same message in a failed test of eth-sig-util:
https://circleci.com/gh/MetaMask/eth-sig-util/48#config/containers/0
MetaMask/eth-sig-util#20
which was resolved by using the renamed method, signTypedDataLegacy

Perhaps the extension is calling signTypedData? Still looking into this will update if I find anything else of interest.

@bdresser
Copy link
Contributor

bdresser commented Aug 8, 2018

hey @1blockologist @evansjohnson - fix was merged for this issue (#4975), should be out later today or tomorrow morning. sorry for the trouble!

@bdresser bdresser closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants