Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Provide Metadata within existent modules #4201

Closed
ghost opened this issue May 6, 2018 · 1 comment
Closed

[TASK] Provide Metadata within existent modules #4201

ghost opened this issue May 6, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented May 6, 2018

Background

The initial plan was to provide a fully redesigned mm-vault module (https://github.com/lazaridiscom/mm-vault). Due to the circumstances, this plan was dropped. This Issue adapts to the new situation.

https://github.com/lazaridiscom/mm-vault#b-integrate-mm-vault-to-main-project-metamask-extension

Description

In order to allow the account-related UI to be generated dynamically, some smaller changes need to be applied to the existent mm-wallets (current naming: keyring classes).

Those additions are non-breaking, thus applying them is non-critical. Here the draft implementation:

In essence, this is not more that adding some metadata to the account-providers (keyring classes). This metadata is then used by the UI subsystem to generate the UI during runtime (not knowing what classes are currently available).

Suggestions

This implementation should be done by @bitpshr (who can alternatively decide to continue the mm-vault redesign, which btw. would be a nice starting-point for TypeScript introduction).

Pitfalls

This task will most possibly emit a cascade of requirements to the main source-code / project.

@ghost ghost changed the title [TASK] Integrate mm-vault changes to existent modules [TASK] Provide Metadata within existent modules Jul 4, 2018
@bdresser
Copy link
Contributor

Closing due to inactivity. please let us know if you'd like to continue the discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant