Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejected Transaction should be removed from unapprovedTxs #3897

Closed
tmashuang opened this issue Apr 5, 2018 · 1 comment
Closed

Rejected Transaction should be removed from unapprovedTxs #3897

tmashuang opened this issue Apr 5, 2018 · 1 comment
Labels
area-UI Relating to the user interface. needs-reproduction type-bug

Comments

@tmashuang
Copy link
Contributor

tmashuang commented Apr 5, 2018

There is some cases where rejected/cancelled transactions do not get out of the unapprovedTxs list, mostly happens when rejecting a transaction supplied by a Dapp. This is not a consistent issue,

"unapprovedTxs": {
 "3239248756227922": {
   "id": 3239248756227922,
   "time": 1522948634588,
   "status": "rejected",
   "metamaskNetworkId": "4",
   "loadingDefaults": false,
   "txParams": {
     "from": "address",
     "to": "address",
     "data": "data hash",
     "gasPrice": "0x4a817c800",
     "description": "blah blah blah",
     "name": "name",
     "gas": "0x75c07",
     "value": "0x0"
   },
  }
}
@bdresser
Copy link
Contributor

fixed in #4667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. needs-reproduction type-bug
Projects
None yet
Development

No branches or pull requests

2 participants