-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject tx on tx window close. #3124
Comments
|
Short term solution is perfect for me :) |
I don't think the "short term solution" of "reject tx on window close" has been implemented yet. I am still not seeing the expected error of "User denied transaction" when I close the transaction window. Is it possible to detect when user closes metamask transaction window instead of cancelling transaction (which is catchable as error)? |
Note that depending on the outcome of this ticket, approval requests should also be rejected in the same manner if the popup is closed. |
Merging #1152 into this, since this has newer content. @danfinlay's main comment from there:
|
From the conversation here and in #1152 we should reject all confirmation popups when closed. |
Originally posted by @farlenkov https://github.com/MetaMask/hello/issues/49
The text was updated successfully, but these errors were encountered: