Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User reports not always broadcasting transactions #2973

Closed
danfinlay opened this issue Jan 15, 2018 · 5 comments
Closed

User reports not always broadcasting transactions #2973

danfinlay opened this issue Jan 15, 2018 · 5 comments
Labels
area-background Issues relating to the extension background process. type-bug

Comments

@danfinlay
Copy link
Contributor

From our gitter, @nikita-fuchs reports that one of his colleagues' metamask installations is failing to broadcast transactions to either Mainnet or testrpc.

From there:

since yesterday, one of my colleague's account's transactions are not being broadcasted at all. the TX of another account are being broadcasted very slowly, >10 minutes and sometimes more. as far as i know, metamask uses infura, and when sending a web3.eth.sendRawTransaction, the callback takes around 10 minutes or more. the other issue is, that even when pointing metamask to a locally running testrpc/ganache, it was not broadcasting the transaction to it at all. the console said it was being waited for (because remix IDE of course wanted the transaction details and constantly did web3.eth.getTransactionReceipt), but that never succeeded, because scrolling further to the top, there was no transaction sent out at all.

Opening this issue to dig into possible causes.

@danfinlay
Copy link
Contributor Author

I would be curious to watch the background network activity when sending a transaction to testrpc. Is one never sent? Is an error returned? http://metamask.helpscoutdocs.com/article/21-how-to-get-logs-and-help-metamask-support-and-diagnose-your-issue

@2-am-zzz 2-am-zzz added type-bug P2-sooner area-background Issues relating to the extension background process. needs-reproduction labels Jan 17, 2018
@maxweng
Copy link

maxweng commented Apr 19, 2018

I'm now experiencing the same issue. I checked the background activity, and there's nothing sent to the testrpc after click the confirm button. But on UI, it said the transaction is approved.

@maxweng
Copy link

maxweng commented Apr 19, 2018

My bad, it looks like the transaction is sent, and the following eth_getBlockByNumber request got the following response.
{"id":6525790472361624,"jsonrpc":"2.0","result":{"number":"0x3","hash":"0x9bb36fb46a1709370f038a771f7f6663efeec95e8818bee904abd587797559e2","parentHash":"0x411b0a854e5f7f99c214a284032abac4cc9e3470b43fb7f5b4dde908c18fd0e9","mixHash":"0x1010101010101010101010101010101010101010101010101010101010101010","nonce":"0x0000000000000000","sha3Uncles":"0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347","logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","transactionsRoot":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","stateRoot":"0x7b6c3cba483245b01e5f4e4effb5e7120dc4d108613a0fb6d052ebb408e0a71d","receiptsRoot":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","miner":"0x0000000000000000000000000000000000000000","difficulty":"0x0","totalDifficulty":"0x0","extraData":"0x00","size":"0x03e8","gasLimit":"0x6691b7","gasUsed":"0x0f8201","timestamp":"0x5ad88128","transactions":["0x765ee761faeaa73571e7a5927208ef03d91de3d9c95de32a393a7cfa85c21537"],"uncles":[]}}

But the testrpc doesn't show 'transaction mined' message. So looks like the transaction failed.

@danfinlay
Copy link
Contributor Author

That response is just a normal block request, we poll for that constantly in the background, it's not really related to the transaction unless it was mined in that block.

@danfinlay
Copy link
Contributor Author

I believe this is fixed by #4557, and will be fixed in our next release (should be very soon!)

pnarayanaswamy added a commit that referenced this issue Sep 10, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Adds an integration test to check that the alert for low gas fees is
displayed

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27015?quickstart=1)

## **Related issues**

Fixes:
[#2973](MetaMask/MetaMask-planning#2973)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-background Issues relating to the extension background process. type-bug
Projects
None yet
Development

No branches or pull requests

3 participants