-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User reports not always broadcasting transactions #2973
Comments
I would be curious to watch the background network activity when sending a transaction to testrpc. Is one never sent? Is an error returned? http://metamask.helpscoutdocs.com/article/21-how-to-get-logs-and-help-metamask-support-and-diagnose-your-issue |
I'm now experiencing the same issue. I checked the background activity, and there's nothing sent to the testrpc after click the confirm button. But on UI, it said the transaction is approved. |
My bad, it looks like the transaction is sent, and the following eth_getBlockByNumber request got the following response. But the testrpc doesn't show 'transaction mined' message. So looks like the transaction failed. |
That response is just a normal block request, we poll for that constantly in the background, it's not really related to the transaction unless it was mined in that block. |
I believe this is fixed by #4557, and will be fixed in our next release (should be very soon!) |
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Adds an integration test to check that the alert for low gas fees is displayed [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27015?quickstart=1) ## **Related issues** Fixes: [#2973](MetaMask/MetaMask-planning#2973) ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
From our gitter, @nikita-fuchs reports that one of his colleagues' metamask installations is failing to broadcast transactions to either Mainnet or testrpc.
From there:
Opening this issue to dig into possible causes.
The text was updated successfully, but these errors were encountered: