[Bug]: Polling initiated in UI sometimes continues when the UI is closed

[Gudahtt]

Describe the bug

Polling initiated in the UI sometimes continues when the UI is closed. Specifically this was encountered with the account-tracker-controller, but it may impact other token-based polling controllers as well.

We have UI code to unregister polling tokens on unmount, but this doesn't always work when the window itself is closed. The process is terminated before the on unmount code finishes.

Expected behavior

When a polling token is registered by a specific UI instance, it should be automatically unregistered when the UI instance closes.

Screenshots/Recordings

No response

Steps to reproduce

This is not a minimal reproduction, but I was able to reproduce this by following the reproduction steps in this issue: #28868

Error messages or log output

Detection stage

On main branch

Version

main

Build type

None

Browser

Other (please elaborate in the "Additional Context" section)

Operating system

Other (please elaborate in the "Additional Context" section)

Hardware wallet

No response

Additional context

I haven't investigated which release this was introduced in. I repro'd it on main, but I expect it impacts prod as well, and has for some time.

Severity

No response

[Gudahtt]

I found a block tracker error that is also causing the polling to continue indefinitely in some cases: MetaMask/eth-block-tracker#301

Not creating a separate issue yet because I am not sure how to repro it without fixing the account tracker controller issue first 😅

[bergeron]

Hoping this will be fixed by #29707

[alfeng6]

should be fixed by the PR mentioned above. If it does not, we can reopen