Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Signature request has different UI on Expanded view #26937

Closed
sleepytanya opened this issue Sep 5, 2024 · 1 comment · Fixed by #26965
Closed

[Bug]: Signature request has different UI on Expanded view #26937

sleepytanya opened this issue Sep 5, 2024 · 1 comment · Fixed by #26965
Assignees
@jpuri
Labels
regression-prod-12.0.0 Regression bug that was found in production in release 12.0.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Sep 5, 2024 •
edited
Loading

Describe the bug

Signature request has different UI on Expanded view

Expected behavior

Consistent UI - we should reduce the size of signatures on fulls screen

Screenshots/Recordings

signTx.mov
Screenshot 2024-09-04 at 21 51 39

Steps to reproduce

  1. Start transaction that requires signature
  2. Switch to Expanded view
  3. Click 'Unapproved Signature request'

Error messages or log output

No response

Detection stage

Production

Version

12.0.0

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@sleepytanya sleepytanya added type-bug Something isn't working team-confirmations Push issues to confirmations team regression-RC-12.2.0 labels Sep 5, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 5, 2024
@bschorchit bschorchit added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Sep 5, 2024
@jpuri jpuri self-assigned this Sep 5, 2024
@sleepytanya sleepytanya added regression-prod-12.0.0 Regression bug that was found in production in release 12.0.0 and removed regression-RC-12.2.0 labels Sep 5, 2024
@sleepytanya
Copy link
Contributor Author

The issue is in production:

signatureProd.mov

@jpuri jpuri mentioned this issue Sep 6, 2024
Merged
7 tasks
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 6, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
@digiwand digiwand mentioned this issue Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
regression-prod-12.0.0 Regression bug that was found in production in release 12.0.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: confirmation screen with in expanded extension view MetaMask/metamask-extension
5 participants
@jpuri @gauthierpetetin @bschorchit @metamaskbot @sleepytanya