Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack: make lavamoat work so we can build --env=production builds #26256

Open
davidmurdoch opened this issue Jul 31, 2024 · 1 comment
Open
Assignees
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. webpack

Comments

@davidmurdoch
Copy link
Contributor

This is already a work in progress.

Related: #26254

@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jul 31, 2024
@davidmurdoch
Copy link
Contributor Author

The lavamoat plugin will be responsible for injecting ses and calling lockdown. We need to figure out if we want to remove the --lockdown option from webpack. I vote for complete removal of the option (effectively making --lavamoat the same as doing --lavamoat --lockdown).

We might need to tweak how lockdown-more.js is injected into the bundle, as well as how snow and use-snow are bundled. Wrapping these in lavamoat runtime would cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. webpack
Projects
None yet
Development

No branches or pull requests

3 participants