Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PermissionLogController from core #23181

Closed
2 of 9 tasks
cryptodev-2s opened this issue Feb 26, 2024 · 0 comments · Fixed by #23182
Closed
2 of 9 tasks

Use PermissionLogController from core #23181

cryptodev-2s opened this issue Feb 26, 2024 · 0 comments · Fixed by #23182
Assignees
@cryptodev-2s
Labels
release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-wallet-framework

Comments

@cryptodev-2s
Copy link
Contributor

What is this about?

Following the successful migration of PermissionLogController from the extension to the core as detailed in MetaMask/core#1826, we should now fully remove the PermissionLogController logic from the extension and instead rely entirely on the core monorepo implementation.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@mcmire mcmire linked a pull request Feb 26, 2024 that will close this issue
feat: remove PermissionLogController in favor of core implementation #23182
Merged
13 tasks
@cryptodev-2s cryptodev-2s self-assigned this Feb 27, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Mar 1, 2024
@MajorLift MajorLift mentioned this issue Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptodev-2s cryptodev-2s

Labels
release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove PermissionLogController in favor of core implementation MetaMask/metamask-extension
2 participants
@metamaskbot @cryptodev-2s