Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigation: examine if we can remove/replace/update ethereumjs-wallet in @metamask/eth-hd-keyring and @metamask/eth-simple-keyring #16513

Closed
adonesky1 opened this issue Nov 15, 2022 · 3 comments
Closed

Investigation: examine if we can remove/replace/update ethereumjs-wallet in @metamask/eth-hd-keyring and @metamask/eth-simple-keyring #16513

adonesky1 opened this issue Nov 15, 2022 · 3 comments
Assignees
@adonesky1 @cryptodev-2s
Labels
MV3 team-extension-platform

Comments

@adonesky1
Copy link
Contributor

adonesky1 commented Nov 15, 2022 •
edited
Loading

Investigation: examine if we can remove/replace/update ethereumjs-wallet in @metamask/eth-hd-keyring and @metamask/eth-simple-keyring smart-transactions-controller and @metamask/controllers @metamask/snap-controller and @metamask/metamask-extension (direct-dep)

Currently direct dep in the extension is v0.6.5 while the rest are 1.0.1 so at the very least lets de-dedupe it.
@adonesky1
Copy link
Contributor Author

will be partially addressed by MetaMask/eth-hd-keyring#69

@cryptodev-2s cryptodev-2s mentioned this issue Dec 7, 2022
Closed
@cryptodev-2s
Copy link
Contributor

should be partially addressed by KeyringController#171

@adonesky1
Copy link
Contributor Author

completed here: MetaMask/eth-hd-keyring@caa0160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonesky1 adonesky1

@cryptodev-2s cryptodev-2s

Labels
MV3 team-extension-platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adonesky1 @hilvmason @cryptodev-2s