Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MV3: Support dapp phishing warning page #15987

Closed
digiwand opened this issue Sep 26, 2022 · 0 comments · Fixed by #16488
Closed

MV3: Support dapp phishing warning page #15987

digiwand opened this issue Sep 26, 2022 · 0 comments · Fixed by #16488
Assignees
@digiwand
Labels
MV3
Milestone
MV3 Implementation

Comments

@digiwand
Copy link
Contributor

digiwand commented Sep 26, 2022 •
edited
Loading

Describe the bug

This support should piggyback off the support we have for dapp pages.

Update logic to only trigger 45 minute keep alive logic on load.

Steps to reproduce

Error messages or log output

No response

Version

10.19.x

Build type

No response

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response
@digiwand digiwand added MV3 PR - P1 identifies PRs deemed priority for Extension team labels Sep 26, 2022
@digiwand digiwand added this to the MV3 Implementation milestone Sep 26, 2022
@digiwand digiwand removed the PR - P1 identifies PRs deemed priority for Extension team label Sep 26, 2022
@digiwand digiwand mentioned this issue Nov 9, 2022
Merged
6 tasks
@digiwand digiwand self-assigned this Nov 11, 2022
@digiwand digiwand mentioned this issue Nov 14, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@digiwand digiwand

Labels
MV3
Projects
None yet
Milestone
MV3 Implementation
Development

Successfully merging a pull request may close this issue.

MV3: support Service Worker restart for phishing warning pages MetaMask/metamask-extension
1 participant
@digiwand