Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ethereumjs/wallet from @metamask/eth-hd-keyring #15907

Closed
adonesky1 opened this issue Sep 20, 2022 · 3 comments
Closed

Remove ethereumjs/wallet from @metamask/eth-hd-keyring #15907

adonesky1 opened this issue Sep 20, 2022 · 3 comments
Assignees
@adonesky1
Labels
MV3 team-extension-platform

Comments

@adonesky1
Copy link
Contributor

adonesky1 commented Sep 20, 2022 •
edited
Loading

briefly discussed here

implementation discussed in twitter dm thread with Paul Miller

working on it here
@adonesky1 adonesky1 added the MV3 label Sep 20, 2022
@adonesky1 adonesky1 self-assigned this Sep 20, 2022
@adonesky1
Copy link
Contributor Author

adonesky1 commented Sep 20, 2022 •
edited
Loading

Need to release a new version of eth-simple-keyring which doesn't depend on ethereumjs/wallet: 4.2.0 currently does

@adonesky1
Copy link
Contributor Author

ethereumjs/wallet was removed from eth-simple-keyring previously here

This was referenced Sep 21, 2022
Merged
Closed
@adonesky1
Copy link
Contributor Author

completed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonesky1 adonesky1

Labels
MV3 team-extension-platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adonesky1 @hilvmason