Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonces not incrementing correctly #1448

Closed
danfinlay opened this issue May 17, 2017 · 2 comments
Closed

Nonces not incrementing correctly #1448

danfinlay opened this issue May 17, 2017 · 2 comments

Comments

@danfinlay
Copy link
Contributor

Currently nonces seem to be based on current account transaction count.

This means that pending transactions aren't counted.

This means that if a new transaction is submitted while another is pending, it will be assigned the same nonce.

This means that if many txs are submitted before any of them are mined, only one of them will eventually be mined.

Parity added a method (nextNonce, noted here) for getting pending transaction count, but it isn't the same as geth's method for getting the pending transaction count.

We should maybe write an adapter for the two of them to replace our nonce tracker subprovider, and use it instead of the current cache strategy.

@kumavis
Copy link
Member

kumavis commented May 19, 2017

might have been due to the lagging infura node, so our base nonce was too low and then when our pending nonces were calculated, it was still off

@danfinlay
Copy link
Contributor Author

I don't know why I opened it, I think I had trouble finding the issue it's a duplicate of, #1127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants