Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mainnet gas price estimates used in send flow on non-Mainnet networks #10003

Closed
Gudahtt opened this issue Dec 4, 2020 · 2 comments · Fixed by #10444
Closed

Mainnet gas price estimates used in send flow on non-Mainnet networks #10003

Gudahtt opened this issue Dec 4, 2020 · 2 comments · Fixed by #10444
Assignees
@NiranjanaBinoy
Labels
area-customNetworks Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug Something isn't working

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Dec 4, 2020 •
edited
Loading

Describe the bug
In the Send flow, the ETH Gas Station "standard" price is used as the default gas price, even when not on Mainnet.

Steps to reproduce (REQUIRED)

  1. Switch to some network other than Mainnet (e.g. Ropsten)
  2. Click "Send" on the Home page
  3. Select one of your accounts
  4. See that the gas price matches the "standard" price on ETH Gas Station

Expected behavior
The default gas price should be determined by eth_gasPrice, as it is for transactions that are sent by dapps via eth_sendTransaction.

Browser details (please complete the following information):

  • OS: Ubuntu
  • Browser: Chrome Version 87.0.4280.66 (Official Build) (64-bit)
  • MetaMask Version: v8.1.6

(Originally reported here by @d10r in #3912 - thanks!)
@Gudahtt Gudahtt added type-bug Something isn't working Sev2-normal Normal severity; minor loss of service or inconvenience. labels Dec 4, 2020
@Gudahtt Gudahtt mentioned this issue Dec 4, 2020
Closed
@wbt wbt mentioned this issue Dec 4, 2020
Closed
This was referenced Jan 7, 2021
Closed
Closed
Closed
@Gudahtt
Copy link
Member Author

Gudahtt commented Jan 19, 2021

Note that we've replaced ETH Gas Station since I created this issue, but the problem is still present. The new gas API estimates are now shown instead of the eth_gasPrice estimates.

@danjm danjm assigned danjm and NiranjanaBinoy and unassigned danjm Jan 22, 2021
@Gudahtt Gudahtt changed the title ETH Gas Station gas price used in send flow on non-Mainnet networks Mainnet gas price estimates used in send flow on non-Mainnet networks Feb 2, 2021
@danfinlay danfinlay mentioned this issue Feb 2, 2021
Closed
@brad-decker brad-decker mentioned this issue Feb 10, 2021
Closed
@brad-decker
Copy link
Contributor

@kevinho reported this issue again in #10416 specifically for huboichain

@tmashuang tmashuang mentioned this issue Feb 12, 2021
Closed
@NiranjanaBinoy NiranjanaBinoy mentioned this issue Feb 13, 2021
Merged
@NiranjanaBinoy NiranjanaBinoy linked a pull request Feb 15, 2021 that will close this issue
Fetch eth_gasprice in send flow on non-Mainnet networks #10444
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels
area-customNetworks Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch eth_gasprice in send flow on non-Mainnet networks MetaMask/metamask-extension
4 participants
@Gudahtt @brad-decker @danjm @NiranjanaBinoy