This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat: remove buildHandlersChain
#114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function lacks many features we expect from a middleware manager, like allowing the inspection of the response. Also, it uses an exception to check if the chain should stop or continue, which can be considered a bad design. However, we add a new `isKeyringRpcMethod` function that allow us to check if a method is a keyring RPC method.
montelaidev
approved these changes
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function lacks many features we expect from a middleware manager, like allowing the inspection of the response. Also, it uses an exception to check if the chain should stop or continue, which can be considered a bad design.
However, we add a new
isKeyringRpcMethodfunction that allow us to check if a method is a keyring RPC method.Closes: #112