This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
chore(deps): update @metamask/keyring-api to version 6.0.0 #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
montelaidev
changed the title
gantunesr
previously approved these changes
Apr 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
montelaidev
force-pushed
the
bump-16-04-2024-keyring-api
branch
from
93e79ea to
3f91e29
Compare
ccharly
changed the title
ccharly
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
LGTM.
For tracking purposes (and to avoid having this in the "resolved comments"):
As discussed together, it's ok to use importTime: 0 on listAccounts because:
importTimeis more the responsibility ofAccountsController- 0 acts as a falsy value, so the
AccountsControllerwould know to update it
cc: @montelaidev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the @metamask/keyring-api dependency to version 6.0.0. It also includes a chore commit to bump the keyring-api version.