Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Node.js version 16 #204

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Minimum Node.js version 16 #204

merged 1 commit into from
Oct 26, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 26, 2023

This is a breaking change

Blocked by

@socket-security
Copy link

socket-security bot commented Oct 26, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/node 20.8.2...16.18.59 None +0/-0 3.51 MB types

- Remove support for major node versions 14,15,17,19
- Set nodejs version 18 in .nvmrc
- ci: Run on Node.js v16,v18,v20 (default v18) instead of
  v14,v16,v18,v19 (default v16)
@legobeat legobeat marked this pull request as ready for review October 26, 2023 21:48
@legobeat legobeat requested a review from a team as a code owner October 26, 2023 21:48
Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@legobeat legobeat merged commit 42143c1 into MetaMask:main Oct 26, 2023
16 checks passed
@legobeat legobeat deleted the node-16 branch October 26, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants