Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: [email protected]>^2.1.0 #196

Merged
merged 1 commit into from
Oct 25, 2023
Merged

deps: [email protected]>^2.1.0 #196

merged 1 commit into from
Oct 25, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 3, 2023

  • bump hdkey from 0.8.0 to ^2.1.0

Supersedes

Related

@legobeat legobeat requested review from darkwing and danjm October 3, 2023 04:22
@legobeat legobeat marked this pull request as ready for review October 3, 2023 04:22
@legobeat legobeat requested a review from a team as a code owner October 3, 2023 04:22
@socket-security
Copy link

socket-security bot commented Oct 3, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
hdkey 0.8.0...2.1.0 None +0/-8 15.3 kB ryanzim

@legobeat legobeat requested review from a team October 3, 2023 04:27
@adonesky1
Copy link
Contributor

adonesky1 commented Oct 4, 2023 •
edited
Loading

It appears the only breaking change is bumping required node version to 10 and this package already requires > v14. Have you verified that there are no other adaptations required @legobeat ?

@legobeat
Copy link
Contributor Author

legobeat commented Oct 4, 2023 •
edited
Loading

It appears the only breaking change is bumping required node version to 10 and this package already requires > v14. Have you verified that there are no other adaptations required @legobeat ?

Should be good. The other potentially breaking change in the package would be cryptocoinjs/hdkey#20, where this package already consistently uses a basePath of m/.

@aloisklink aloisklink mentioned this pull request Oct 4, 2023
Merged
@legobeat legobeat requested a review from adonesky1 October 7, 2023 02:35
@legobeat legobeat mentioned this pull request Oct 10, 2023
Closed
@legobeat legobeat requested a review from mikesposito October 10, 2023 23:10
@legobeat legobeat requested review from a team and kumavis October 23, 2023 09:35
@legobeat legobeat merged commit d587771 into MetaMask:main Oct 25, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

@darkwing darkwing Awaiting requested review from darkwing

@danjm danjm Awaiting requested review from danjm

@mikesposito mikesposito Awaiting requested review from mikesposito

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @adonesky1