Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs engine #169

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Update nodejs engine #169

merged 3 commits into from
Feb 23, 2023

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Feb 22, 2023

This PR updates the nodejs .nvmrc version and the minimum required version for this package.

  • .nvmrc file version: v12 -> v16
  • engine min accepted version v12 -> v14
  • use v14 in circle-ci jobs

Resolves #168

@mikesposito mikesposito requested a review from a team as a code owner February 22, 2023 10:11
@mikesposito mikesposito self-assigned this Feb 22, 2023
@Gudahtt
Copy link
Member

Gudahtt commented Feb 22, 2023

Curious why v16 was used in CI if v14 is the minimum supported version. That could leave v14 compatibility problems undetected by CI

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito merged commit 14208d7 into main Feb 23, 2023
@mikesposito mikesposito deleted the chore/update-node-to-16 branch February 23, 2023 09:00
@Gudahtt Gudahtt mentioned this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update node engine to v14
2 participants