Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for keyring to receive connection status #131

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Dec 6, 2021

This PR will receive messages from the gh-pages branch and exposes isConnected for the keyring.

@darkwing darkwing requested a review from a team as a code owner December 6, 2021 19:08
@danjm
Copy link
Contributor

danjm commented Feb 2, 2022

this PR looks fine

@darkwing darkwing force-pushed the ledger-connect-status branch 3 times, most recently from 41e9f7b to 1b29d65 Compare February 10, 2022 17:44
@darkwing darkwing force-pushed the ledger-connect-status branch from 0fa2047 to d94a4aa Compare February 19, 2022 15:51
@darkwing
Copy link
Contributor Author

darkwing commented Mar 1, 2022

Debug has been removed from here.

@darkwing darkwing merged commit bd5eaa7 into main Mar 2, 2022
@darkwing darkwing deleted the ledger-connect-status branch March 2, 2022 14:42
julianariel pushed a commit to block-wallet/eth-ledger-bridge-keyring that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants