Allow connection via WebHID in iframe #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2021
Gudahtt
reviewed
Sep 29, 2021
| @@ -424,6 +424,7 @@ class LedgerBridgeKeyring extends EventEmitter { | |||
| _setupIframe () { | |||
| this.iframe = document.createElement('iframe') | |||
| this.iframe.src = this.bridgeUrl | |||
| this.iframe.allow = `hid 'src'` | |||
There was a problem hiding this comment.
Interesting that this wasn't documented on MDN on the list of features this allowlist applies to, but I did find it in the WebHID spec: https://wicg.github.io/webhid/#permissions-policy
There was a problem hiding this comment.
oh, yeah, that's how I found that as well. I should have put that in the PR description.
julianariel
pushed a commit
to block-wallet/eth-ledger-bridge-keyring
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is necessary for the use of WebHID in the ledger-bridge
Associated PR: #106