Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry JSON RPC requests on hitting rate limit #235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mitinarseny
Copy link

No description provided.

@mitinarseny mitinarseny marked this pull request as ready for review August 8, 2023 14:27
@mitinarseny mitinarseny requested a review from a team as a code owner August 8, 2023 14:27
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mitinarseny. Would you mind explaining the purpose of this PR — what problem it's intended to solve and how you solved it?

Also, would you mind adding some tests for this middleware so we can ensure it works as intended going forward? Unfortunately there isn't a set standard for tests in this project but you can kind of get a sense from https://github.com/MetaMask/eth-json-rpc-middleware/blob/main/src/inflight-cache.test.ts and https://github.com/MetaMask/eth-json-rpc-middleware/blob/main/src/retryOnEmpty.test.ts#L120 for some inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants