-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 161.0.0 #4413
Merged
Merged
Release 161.0.0 #4413
Changes from 14 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
233b705
Initialize Release 161.0.0
ccharly 25a6c51
Update Release 161.0.0
ccharly 7beeba9
chore: update accounts-controller CHANGELOG.md
ccharly 9f61b2b
chore: update assets-controller CHANGELOG.md
ccharly dc93145
chore: update chain-controller CHANGELOG.md
ccharly 1215152
chore: update keyring-controller CHANGELOG.md
ccharly b57a7f8
chore: update selected-network-controller CHANGELOG.md
ccharly ec719c8
chore: update transaction-controller CHANGELOG.md
ccharly e631ca5
chore: yarn constraints --fix
ccharly dc2a863
chore: update changelogs after for constraints fixes
ccharly 43da8a8
chore: yarn.lock
ccharly c3d89d6
chore: fix changelog for assets-controllers
ccharly 009d5b8
chore: update changelog for transaction-controller
ccharly ddeef9d
chore: update changelog for keyring-controller
ccharly a7710db
chore: update assets-controllers CHANGELOG.md
ccharly faa8750
chore: update assets-controllers CHANGELOG.md
ccharly b7fdc16
fix: fix assets-controllers CHANGELOG.md
ccharly b998da8
chore: re-categorized some changes in assets-controllers CHANGELOG.md
ccharly 4cd1d52
chore: update changelog entry for assets-controllers CHANGELOG.md
ccharly 8b7ae3d
chore: update changelog entry for assets-controllers CHANGELOG.md
ccharly 451d356
chore: re-categorized some changes in assets-controllers CHANGELOG.md
ccharly b6bc2d9
chore: update assets-controllers CHANGELOG.md
ccharly 18a8a48
chore: update assets-controllers CHANGELOG.md
ccharly 13d91ae
chore: initial release for chain-controller
ccharly c9a6139
chore: update entries for #4314
ccharly 37bc182
chore: update assets-controllers CHANGELOG.md
ccharly f71d036
chore: update assets-controllers CHANGELOG.md
ccharly 374c25b
chore: update transaction-controller CHANGELOG.md
ccharly 83c5a8f
chore: update changelog for transaction-controller
ccharly f273f6e
chore: update changelog for assets-controller
ccharly 347751f
chore: update changelog for transaction-controller
ccharly 16aed63
chore: update changelog for keyring-controller
ccharly f15f107
Merge branch 'main' into release/161.0.0
ccharly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [17.0.0] | ||
|
|
||
| ### Changed | ||
|
|
||
| - **BREAKING:** Newly added account is no longer set as the last selected account ([#4363](https://github.com/MetaMask/core/pull/4363)) | ||
| - Bump `@metamask/eth-snap-keyring` to `^4.3.1` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
| - Bump `@metamask/keyring-api` to `^8.0.0` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
| - Bump `@metamask/keyring-controller` to `^17.1.0` (`devDependencies`) ([#4413](https://github.com/MetaMask/core/pull/4413)) | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Use `listMultichainAccount` in `getAccountByAddress` ([#4375](https://github.com/MetaMask/core/pull/4375)) | ||
|
|
||
| ## [16.0.0] | ||
|
|
||
| ### Changed | ||
|
|
@@ -202,7 +215,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| - Initial release ([#1637](https://github.com/MetaMask/core/pull/1637)) | ||
|
|
||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [17.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [16.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [15.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [14.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,38 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [33.0.0] | ||
|
|
||
| ### Added | ||
|
|
||
| - Added `Mutex` lock in the `updateNftMetadata` function ([#4325](https://github.com/MetaMask/core/pull/4325)) | ||
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - Token price API support for mantle network ([#4376](https://github.com/MetaMask/core/pull/4376)) | ||
|
|
||
| ### Changed | ||
|
|
||
| - **BREAKING:** `NftController` constructor argument `selectedAddress` has been removed. ([#4221](https://github.com/MetaMask/core/pull/4221)) | ||
| - **BREAKING:** `NftController` now requires `AccountsController:get{Account,SelectedAccount}` messenger actions. ([#4221](https://github.com/MetaMask/core/pull/4221)) | ||
| - **BREAKING:** `NftController` now requires `AccountsController:selectedEvmAccountChange` event. ([#4221](https://github.com/MetaMask/core/pull/4221)) | ||
| - **BREAKING:** `NftDetectionController` now requires `AccountsControlelr:getSelectedAccount` messenger actions. ([#4221](https://github.com/MetaMask/core/pull/4221)) | ||
| - **BREAKING:** `AccountTrackerController` now requires a controller messenger ([#4225](https://github.com/MetaMask/core/pull/4225)) | ||
| - **BREAKING:** Removed `getIdentities`, `getSelectedAddress` and `onPreferencesStateChange` from the constructor arguments of the `AccountTrackerController` ([#4225](https://github.com/MetaMask/core/pull/4225)) | ||
| - **BREAKING:** Bump dependency and peer dependency `@metamask/accounts-controller` to `^17.0.0` ([#4413](https://github.com/MetaMask/core/pull/4413)) | ||
| - Upgrade `TokenRatesController` to `BaseControllerV2` ([#4314](https://github.com/MetaMask/core/pull/4314)) | ||
mcmire marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - Update Nft controllers to use `selectedAccountId` instead of `selectedAddress` ([#4221](https://github.com/MetaMask/core/pull/4221)) | ||
mcmire marked this conversation as resolved.
Show resolved
Hide resolved
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - `TokenRatesController` uses checksum instead of lowercase format for token addresses ([#4377](https://github.com/MetaMask/core/pull/4377)) | ||
mcmire marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - Bump `@metamask/keyring-api` to `^8.0.0` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
| - Bump `@metamask/eth-snap-keyring` to `^4.3.1` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
| - Bump `@metamask/keyring-controller` to `^17.1.0` ([#4413](https://github.com/MetaMask/core/pull/4413)) | ||
|
|
||
| ### Removed | ||
|
|
||
| - Remove `value` from price API responses ([#4364](https://github.com/MetaMask/core/pull/4364)) | ||
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ### Fixed | ||
|
|
||
| - Catch the case when data are not available for given token ([#4361](https://github.com/MetaMask/core/pull/4361)) | ||
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - Mutex released on the finally block of refresh function ([#4270](https://github.com/MetaMask/core/pull/4270)) | ||
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ## [32.0.0] | ||
|
|
||
| ### Changed | ||
|
|
@@ -889,7 +921,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| - Use Ethers for AssetsContractController ([#845](https://github.com/MetaMask/core/pull/845)) | ||
|
|
||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [33.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [32.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [31.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [30.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## [Unreleased] | ||
|
|
||
| [Unreleased]: https://github.com/MetaMask/core/ | ||
| ## [0.1.0] | ||
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/keyring-api` to `^8.0.0` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
| - Bump `@metamask/eth-snap-keyring` to `^4.3.1` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [0.1.0]: https://github.com/MetaMask/core/releases/tag/@metamask/[email protected] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,8 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [17.1.0] | ||
|
|
||
| ### Changed | ||
|
|
||
| - Add support for overwriting built-in keyring builders for the Simple and HD keyring ([#4362](https://github.com/MetaMask/core/pull/4362)) | ||
mcmire marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - Bump `@metamask/eth-snap-keyring` to `^4.3.1` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
| - Bump `@metamask/keyring-api` to `^8.0.0` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
|
|
||
| ### Deprecated | ||
|
|
||
| - Deprecate QR keyring methods ([#4365](https://github.com/MetaMask/core/pull/4365)) | ||
| - `cancelQRSignRequest` | ||
| - `cancelQRSynchronization` | ||
|
|
@@ -486,7 +494,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| All changes listed after this point were applied to this package following the monorepo conversion. | ||
|
|
||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [17.1.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [17.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [16.1.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [16.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [15.0.2] | ||
|
|
||
| ### Fixed | ||
|
|
||
| - `setNetworkClientId()` no longer modifies state nor creates/updates proxies when the `useRequestQueuePreference` flag is false ([#4388](https://github.com/MetaMask/core/pull/4388)) | ||
|
|
||
| ## [15.0.1] | ||
|
|
||
| ### Fixed | ||
|
|
@@ -229,7 +235,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| - Initial Release ([#1643](https://github.com/MetaMask/core/pull/1643)) | ||
|
|
||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [15.0.2]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [15.0.1]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [15.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [14.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [33.0.0] | ||
|
|
||
| ### Changed | ||
|
|
||
| - **BREAKING:** `getSelectedAddress` is replaced with `getSelectedAccount` in the `TransactionController` ([#4244](https://github.com/MetaMask/core/pull/4244)) | ||
ccharly marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - **BREAKING:** `getCurrentAccount` returns an `InternalAccount` instead of a `string` in the `IncomingTransactionHelper` ([#4244](https://github.com/MetaMask/core/pull/4244)) | ||
| - **BREAKING:** Bump dependency and peer dependency `@metamask/accounts-controller` to `^17.0.0` ([#4413](https://github.com/MetaMask/core/pull/4413)) | ||
| - Bump `@metamask/eth-snap-keyring` to `^4.3.1` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
| - Bump `@metamask/keyring-api` to `^8.0.0` ([#4405](https://github.com/MetaMask/core/pull/4405)) | ||
|
|
||
| ### Fixed | ||
|
|
||
| - `MultichainTrackingHelper.getEthQuery` now returns global `ethQuery` with ([#4390](https://github.com/MetaMask/core/pull/4390)) | ||
| - Support skipping updates to the simulation history for clients with disabled history ([#4349](https://github.com/MetaMask/core/pull/4349)) | ||
|
|
||
| ## [32.0.0] | ||
|
|
||
| ### Changed | ||
|
|
@@ -876,7 +891,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| All changes listed after this point were applied to this package following the monorepo conversion. | ||
|
|
||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/[email protected] | ||
| [33.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [32.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [31.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
| [30.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm we generally don't include devDeps bumps in the changelog, but I'm not sure why keyring-controller isn't a dependency.
That might be a holdover from a past state when keyring-controller only supplied types to accounts-controller?
@mcmire Should we recategorize keyring-controller as a dependency for accounts-controller at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with doing that in another PR as well.
This isn't the only case I've seen where a package needed to be moved to a different level. So we (Wallet Framework team) should probably go through all packages and audit them to ensure that any controller package that should be in
dependenciesand/orpeerDependenciesshould be there. In addition I think knowing how to express dependencies on packages that are only for types — and knowing how to express dependencies that are used in conjunction with the messenger — has been a constant source of confusion, we should add documentation somewhere that explains our position.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, this should be moved to dependency now. To not block this release, i'll update this in another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh weird my comment got added in the wrong place. Well you got the idea :)