-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving json-rpc-middleware-stream from merged-packages to actual pack… #1762
Conversation
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @lavamoat/[email protected], @metamask/[email protected], @types/[email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected] |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
ea8975c
to
f7ae183
Compare
Per standup, we should take a look at the migration checklist for this package again as it may have changed since this PR was created. If there are any PRs we need to merge before this one can go in then we should take care of that first. |
…d validate-changelog.sh
…ts.pro and validation-changelog.sh
…ts.pro and validation-changelog.sh
…ts.pro and validation-changelog.sh
…com:MetaMask/core into json-rpc-middleware-stream-to-core-packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finished testing the tag porting script, and I think it will be safer to run it before the package is moved out of merged-packages/
.
So #1802 will need to be merged before this PR can be merged. Sorry for the confusion!
284bc66
to
c1423be
Compare
- should have been removed in step B-2
504f5ef
to
a04e8b0
Compare
a04e8b0
to
52ebe29
Compare
3596602
to
a985575
Compare
|
cf74a67
to
7f5e3b5
Compare
2e628b7
to
28782b2
Compare
2bc0106
to
58e7d0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Explanation
We chose to place json-rpc-middleware-stream initially in the merged-packages and not packages so we can hide it from Yarn, ESLint, Prettier, and TypeScript. In this PR, we cleaned it up and moved it from
merged-packages
to actualpackages
folder.In this process, we followed below steps.
Moving to packages
yarn workspace @metamask/json-rpc-middleware-stream test
.Lints and Constraints
yarn lint
errorsyarn constraints
errorsyarn workspace @metamask/json-rpc-middleware-stream changelog:validate
References
Changelog Updates
@metamask/json-rpc-middleware-stream
json-rpc-middleware-stream
to@metamask/json-rpc-middleware-stream
Checklist