From 181cd7e54283b3c7d5204a584b881c0a2fd1693c Mon Sep 17 00:00:00 2001 From: Salah-Eddine Saakoun Date: Mon, 26 Feb 2024 15:02:31 +0100 Subject: [PATCH] refactor(controller-utils): replace with in isNetworkType --- packages/controller-utils/src/types.test.ts | 2 ++ packages/controller-utils/src/types.ts | 6 ++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/controller-utils/src/types.test.ts b/packages/controller-utils/src/types.test.ts index ddac15c4999..8d1de7df7cb 100644 --- a/packages/controller-utils/src/types.test.ts +++ b/packages/controller-utils/src/types.test.ts @@ -2,7 +2,9 @@ import { isNetworkType, NetworkType } from './types'; describe('types', () => { it('isNetworkType', () => { + // @ts-expect-error We are intentionally passing bad input. expect(isNetworkType({})).toBe(false); + // @ts-expect-error We are intentionally passing bad input. expect(isNetworkType(1)).toBe(false); expect(isNetworkType('test')).toBe(false); expect(isNetworkType('mainnet')).toBe(true); diff --git a/packages/controller-utils/src/types.ts b/packages/controller-utils/src/types.ts index 248d7623b9e..1cfad3a3e13 100644 --- a/packages/controller-utils/src/types.ts +++ b/packages/controller-utils/src/types.ts @@ -28,10 +28,8 @@ export type NetworkType = (typeof NetworkType)[keyof typeof NetworkType]; * @param val - the value to check whether it is NetworkType or not. * @returns boolean indicating whether or not the argument is NetworkType. */ -// TODO: Replace `any` with type -// eslint-disable-next-line @typescript-eslint/no-explicit-any -export function isNetworkType(val: any): val is NetworkType { - return Object.values(NetworkType).includes(val); +export function isNetworkType(val: string): val is NetworkType { + return Object.values(NetworkType).includes(val as NetworkType); } /**