Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chain_getBalances #1

Merged
merged 20 commits into from
Apr 30, 2024
Merged

feat: add chain_getBalances #1

merged 20 commits into from
Apr 30, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Apr 17, 2024

Description

This is the very first operation of the chain API.

@ccharly ccharly requested a review from a team as a code owner April 17, 2024 10:21
Copy link

socket-security bot commented Apr 17, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@ccharly ccharly marked this pull request as draft April 22, 2024 13:02
@ccharly ccharly force-pushed the feature/chain_getBalances branch from c3703a9 to be137eb Compare April 24, 2024 09:41
@ccharly ccharly force-pushed the feature/chain_getBalances branch from be137eb to 8d089b9 Compare April 24, 2024 12:53
@ccharly ccharly force-pushed the feature/chain_getBalances branch from 8d089b9 to 74d7db1 Compare April 25, 2024 15:01
@ccharly
Copy link
Contributor Author

ccharly commented Apr 25, 2024

For the record, I'll ignore micro-ftch since this dependency is also present on https://github.com/MetaMask/utils:

So I assume we're ok with this warning from socket.

@ccharly
Copy link
Contributor Author

ccharly commented Apr 25, 2024

@SocketSecurity ignore npm/[email protected]

@ccharly
Copy link
Contributor Author

ccharly commented Apr 25, 2024

There's an on-going PR for the support of CAIP-19 here:

(Still a draft for now, waiting for this PR to be merged and get some review first before marking it as ready on @metamask/utils)

@ccharly ccharly force-pushed the feature/chain_getBalances branch 2 times, most recently from 8fc2007 to 8e7dd90 Compare April 26, 2024 08:12
We do use a resolution for this to make sure @metamask/utils also uses
the 1.0.3 (and avoid having different versions of superstruct, that
might cause typing issues see like:
https://github.com/MetaMask/chain-api/actions/runs/8836209841/job/24262243391?pr=1)
@ccharly ccharly force-pushed the feature/chain_getBalances branch from 8e7dd90 to 0b9d38a Compare April 26, 2024 08:20
@ccharly ccharly marked this pull request as ready for review April 26, 2024 08:22
@ccharly
Copy link
Contributor Author

ccharly commented Apr 26, 2024

Some words on why I have downgraded to [email protected]:

Also, socket was emitting a warning on [email protected] cause the author did change, and since we are using the 1.0.3 on other repos, I wanted to stick with this one.

montelaidev
montelaidev previously approved these changes Apr 30, 2024
src/JsonRpcRequest.ts Outdated Show resolved Hide resolved
src/superstruct.ts Outdated Show resolved Hide resolved
@ccharly ccharly merged commit a6e2382 into main Apr 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants