-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chain_getBalances #1
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
c3703a9
to
be137eb
Compare
Having an extra dependency to the keyring-api feels wrong... So for now, let's copy them here to avoid this dependency.
be137eb
to
8d089b9
Compare
8d089b9
to
74d7db1
Compare
For the record, I'll ignore
So I assume we're ok with this warning from socket. |
@SocketSecurity ignore npm/[email protected] |
There's an on-going PR for the support of CAIP-19 here: (Still a draft for now, waiting for this PR to be merged and get some review first before marking it as ready on |
8fc2007
to
8e7dd90
Compare
We do use a resolution for this to make sure @metamask/utils also uses the 1.0.3 (and avoid having different versions of superstruct, that might cause typing issues see like: https://github.com/MetaMask/chain-api/actions/runs/8836209841/job/24262243391?pr=1)
8e7dd90
to
0b9d38a
Compare
Some words on why I have downgraded to
Also, |
Description
This is the very first operation of the chain API.