Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keyring-eth-ledger-bridge)!: enable ledger clear signing #99

Merged
merged 15 commits into from
Dec 9, 2024

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Nov 22, 2024

The original feature requirement is listed here:

This PR will enable clear signing feature in signTransaction and signEIP712 typed data in @metamask/eth-ledger-keyring-bridge library. please refer to ledger official document for detail: https://developers.ledger.com/docs/clear-signing/getting-started

This PR has done following changes:

  1. change the deviceSignTypedData and deviceSignTransaction method to use new API suggested by ledger team which support clear signing.
  2. change ledger-keyring.ts to adapt new API format for deviceSignTypedData.
  3. fix all unit tests issue.

@dawnseeker8 dawnseeker8 requested a review from a team as a code owner November 22, 2024 08:49
@dawnseeker8 dawnseeker8 added the team-accounts This should be handled by the Accounts Team label Nov 22, 2024
@ccharly ccharly changed the title Feat/enable ledger clear signing feat(keyring-eth-ledger-bridge): enable ledger clear signing Dec 3, 2024
@ccharly ccharly changed the title feat(keyring-eth-ledger-bridge): enable ledger clear signing feat(keyring-eth-ledger-bridge)!: enable ledger clear signing Dec 3, 2024
@dawnseeker8
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link

github-actions bot commented Dec 3, 2024

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "11.1.0-e345222",
  "@metamask-previews/eth-hd-keyring": "9.0.0-e345222",
  "@metamask-previews/eth-ledger-bridge-keyring": "7.0.0-e345222",
  "@metamask-previews/eth-simple-keyring": "8.0.0-e345222",
  "@metamask-previews/eth-trezor-keyring": "6.0.0-e345222",
  "@metamask-previews/eth-snap-keyring": "6.0.0-e345222"
}

@dawnseeker8 dawnseeker8 requested a review from ccharly December 4, 2024 12:59
yarn.lock Outdated Show resolved Hide resolved
@dawnseeker8 dawnseeker8 requested a review from ccharly December 5, 2024 12:15
@dawnseeker8
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link

github-actions bot commented Dec 6, 2024

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "11.1.0-dde1dbb",
  "@metamask-previews/eth-hd-keyring": "9.0.0-dde1dbb",
  "@metamask-previews/eth-ledger-bridge-keyring": "7.0.0-dde1dbb",
  "@metamask-previews/eth-simple-keyring": "8.0.0-dde1dbb",
  "@metamask-previews/eth-trezor-keyring": "6.0.0-dde1dbb",
  "@metamask-previews/eth-snap-keyring": "6.0.0-dde1dbb"
}

@Akaryatrh Akaryatrh force-pushed the feat/enable-ledger-clear-signing branch from 6c2dbfc to 47e7cbf Compare December 9, 2024 09:27
@ccharly ccharly added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 8b319d8 Dec 9, 2024
29 checks passed
@ccharly ccharly deleted the feat/enable-ledger-clear-signing branch December 9, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-accounts This should be handled by the Accounts Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants