generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(keyring-eth-ledger-bridge)!: enable ledger clear signing #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawnseeker8
commented
Nov 26, 2024
mikesposito
reviewed
Dec 3, 2024
ccharly
changed the title
Feat/enable ledger clear signing
feat(keyring-eth-ledger-bridge): enable ledger clear signing
Dec 3, 2024
ccharly
changed the title
feat(keyring-eth-ledger-bridge): enable ledger clear signing
feat(keyring-eth-ledger-bridge)!: enable ledger clear signing
Dec 3, 2024
@metamaskbot publish-preview |
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions.
|
ccharly
reviewed
Dec 4, 2024
packages/keyring-eth-ledger-bridge/src/ledger-iframe-bridge.test.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Dec 5, 2024
@metamaskbot publish-preview |
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions.
|
…Transaction api for clear signing.
…tive compatible approach for mobile.
…ts to update the coverage.
Co-authored-by: Charly Chevalier <[email protected]>
Co-authored-by: Charly Chevalier <[email protected]>
Akaryatrh
force-pushed
the
feat/enable-ledger-clear-signing
branch
from
December 9, 2024 09:27
6c2dbfc
to
47e7cbf
Compare
ccharly
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original feature requirement is listed here:
This PR will enable clear signing feature in
signTransaction
andsignEIP712
typed data in@metamask/eth-ledger-keyring-bridge
library. please refer to ledger official document for detail: https://developers.ledger.com/docs/clear-signing/getting-startedThis PR has done following changes:
deviceSignTypedData
anddeviceSignTransaction
method to use new API suggested by ledger team which support clear signing.ledger-keyring.ts
to adapt new API format fordeviceSignTypedData
.