-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: build packages with ts-bridge
#40
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
ts-bridge
ts-bridge
Might want to couple this with an upgrade of |
eed9d22
to
c4cdc3f
Compare
e0cc9a0
to
3416820
Compare
ts-bridge
ts-bridge
@metamaskbot publish-previews |
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions.
|
I was able to run the E2E tests on the extension side using a bunch of previews builds, everything looks fine. Some tests are failing, but I truly think this is not related to that PR, but more about the latest changes we made on the mainline (the extension + the Here's the PRs I used for tests:
|
Just upgrading to the latest stable TypeScript version. This is also related to this comment: #40 (comment).
This updates all packages to build with
ts-bridge
instead oftsc
. This has the benefit that packages will be built as CJS modules and ESM modules at the same time.I've also modernised
eth-hd-keyring
in this process, as it was previously a single JS file. For now it's running TypeScript withallowJs
, but this file can be properly converted to TypeScript in the future.Breaking changes
exports
field, meaning subpath imports (import '@metamask/eth-hd-keyring/dist/foo';
) are no longer possible, unless explicitly stated in the exports field.