Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 1.0.0 #38

Merged
merged 4 commits into from
Sep 18, 2024
Merged

release: 1.0.0 #38

merged 4 commits into from
Sep 18, 2024

Conversation

ccharly
Copy link
Collaborator

@ccharly ccharly commented Sep 18, 2024

Description

This is the release candidate for version . See the changelogs for more details.

Related PRs

There was 2 attempts to create this release already:

  1. release: 1.0.0 #31
  1. release: 1.0.0 #37

Git

The 2 previous PRs have been removed from the history to avoid having multiple release: 1.0.0 commits.

@ccharly ccharly requested a review from a team as a code owner September 18, 2024 09:11
@ccharly ccharly changed the title release: release: 1.0.0 Sep 18, 2024
danroc
danroc previously approved these changes Sep 18, 2024
@ccharly ccharly added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 3536279 Sep 18, 2024
23 checks passed
@ccharly ccharly deleted the release/1.0.0 branch September 18, 2024 09:34
@ccharly ccharly mentioned this pull request Sep 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 18, 2024
## Description

This is the release candidate for version . See the changelogs for more
details.

## Related PRs

1. This was the 3rd attempt for this release, it did not work because
the commit name was wrong (`release: 1.0.0` instead of `release:
1.0.0`). We might wanna relax this "strict" check in the future, or
maybe have more CI tooling to verify PRs title (at least for releases).
  - #38
-
https://github.com/MetaMask/accounts/actions/runs/10919514167/job/30307460716

## Git

The previous PR has been removed from the history to avoid having
multiple `release: 1.0.0` commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants