Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: latency not correct when set custom url in config #1189

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

njzydark
Copy link
Contributor

Currently, there are two main issues with latency testing:

  1. When there is a custom testUrl in the configuration file, clicking the speed test does not use the URL from the config file, but instead uses the global configuration
  2. The current implementation logic is not strongly bound to testUrl. When fixing the first issue, it causes all identical proxy nodes across different proxy groups to have the same latency time, and their corresponding historical speed test results are also incorrect. This behavior is not as expected

To thoroughly fix this issue, all latency-related logic needs to be strongly bound to testurl


Example Config:

  - name: SteamDirect
    type: select
    proxies:
      - DIRECT
      - Proxy
  - name: Home
    type: select
    proxies:
      - DIRECT
      - xray-home
    url: http://wifi.vivo.com.cn/generate_204

before fix:

image

after fix:

image

To thoroughly fix this issue, all latency-related logic needs to be strongly bound to testurl
@kunish
Copy link
Collaborator

kunish commented Nov 26, 2024

Thanks for the detailed explaination.

@kunish
Copy link
Collaborator

kunish commented Nov 26, 2024

This is a relatively large change set. Allow me to find some spare time to review.

@kunish
Copy link
Collaborator

kunish commented Nov 27, 2024

LGTM :)

@kunish kunish merged commit af30813 into MetaCubeX:main Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants