Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies with configurations handling in the flow test is annoying #184

Closed
benlapETS opened this issue Apr 17, 2019 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request likely-fixed likely fix is in the repository, success not confirmed yet.

Comments

@benlapETS
Copy link
Contributor

benlapETS commented Apr 17, 2019

As it is now, the flow test cannot be run if we got trailing config from other cases. We have to cleanup everything manually each time we want to run a test (and backup what we would like to keep for later recovering it). This is due to the fact that we properly filter examples needed, when gathering and removing it, but we use sr start, stop, cleanup to do the rest which use everthing. I see three way to fix this issue:

  • We start each component separately within the flow test script (the same way we are filtering component with add and remove), this is my first idea and this does not work well because of issues with logging that are too complicated to solve right now, because of poor design Logging structure is poorly designed and poorly implemented #185 .
  • We use a custom config path for testing (ie. ~/git/sarracenia/sarra/example/*/<flow_test_file>.conf), thus directly from examples config instead of copying them...
  • We backup the config before the flow test and we recover everything after it (ie. using tar).
@benlapETS benlapETS self-assigned this Apr 18, 2019
@benlapETS benlapETS added enhancement New feature or request likely-fixed likely fix is in the repository, success not confirmed yet. labels Apr 26, 2019
@benlapETS
Copy link
Contributor Author

We decided to go with the by component solution (1st option) and I figured out to manage the logging by piping output through the flow scripts, to log files related to flow_ (action in {setup, cleanup}). It cleaned a bit the output of the flow test in the console while keeping a trace of the last run problems.

@benlapETS
Copy link
Contributor Author

Nothing bad happened with our flow test after this implementation, resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request likely-fixed likely fix is in the repository, success not confirmed yet.
Projects
None yet
Development

No branches or pull requests

1 participant