Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing fiat currencies (govt. issued centralised dumb money) like USD, EUR, etc. in app at relevant places #15

Open
satindergrewal opened this issue May 25, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request phase 2 Extended the abilities of wallet bit further, making it bit more user friendlier
Milestone

Comments

@satindergrewal
Copy link
Member

satindergrewal commented May 25, 2021

We should think about modifying the UI/UX a little bit to have place to display the fiat (govt. issued centralised dumb money) i.e. USD, EUR etc in application wherever relevant.

For this feature, I'd highly recommend checking out Mycelium wallet on Android. Take the idea of displaying fiat converted balance exactly how Mycelium does, or at least influenced by it.

Coinpaprika provides API to get Pirate Chain's price data, which we can use to get started:

➜  ~ curl -s https://api.coingecko.com/api/v3/coins/markets\?vs_currency\=usd\&ids\=pirate-chain\&order\=market_cap_desc\&per_page\=100\&page\=1\&sparkline\=false\&price_change_percentage\=1h%2C%2024h%2C%207d%2C%2030d | jq
[
  {
    "id": "pirate-chain",
    "symbol": "arrr",
    "name": "Pirate Chain",
    "image": "https://assets.coingecko.com/coins/images/6905/large/Pirate_Chain.png?1560913844",
    "current_price": 4.47,
    "market_cap": 812017105,
    "market_cap_rank": 95,
    "fully_diluted_valuation": null,
    "total_volume": 2952260,
    "high_24h": 4.62,
    "low_24h": 3.45,
    "price_change_24h": 1.02,
    "price_change_percentage_24h": 29.53878,
    "market_cap_change_24h": 188313761,
    "market_cap_change_percentage_24h": 30.19284,
    "circulating_supply": 181820207.53912,
    "total_supply": 200000000,
    "max_supply": null,
    "ath": 16.76,
    "ath_change_percentage": -73.43995,
    "ath_date": "2021-04-23T18:13:27.423Z",
    "atl": 0.00797788,
    "atl_change_percentage": 55699.79813,
    "atl_date": "2020-11-26T02:10:52.806Z",
    "roi": null,
    "last_updated": "2021-05-25T11:28:29.355Z",
    "price_change_percentage_1h_in_currency": 0.08861843927950086
  }
]
@satindergrewal satindergrewal added the enhancement New feature or request label May 25, 2021
@satindergrewal satindergrewal added this to the Release v1.0 milestone May 25, 2021
@satindergrewal satindergrewal added the phase 2 Extended the abilities of wallet bit further, making it bit more user friendlier label May 27, 2021
@satindergrewal satindergrewal changed the title Showing fait currencies (govt. issued centralised dumb money) like USD, EUR, etc. in app at relevant places Showing fiat currencies (govt. issued centralised dumb money) like USD, EUR, etc. in app at relevant places May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request phase 2 Extended the abilities of wallet bit further, making it bit more user friendlier
Projects
None yet
Development

No branches or pull requests

2 participants