Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Exclude operation authorization notice #289

Open
ktsuench opened this issue Dec 16, 2019 · 2 comments
Open

Feature request: Exclude operation authorization notice #289

ktsuench opened this issue Dec 16, 2019 · 2 comments

Comments

@ktsuench
Copy link

Is your feature request related to a problem? Please describe.
It would be nice if we could exclude the operation authorization notice.

Describe the solution you'd like
It would be as simple as modifying the template file that includes that snippet. I already have a working PR I will be submitting after this issue is opened.

Describe alternatives you've considered
Well another alternative would be to accept that the operations authorization notice is always included. But that's not a good solution, especially if they weren't needed to begin with.

Additional context
N/A

@MikeRalphson
Copy link
Contributor

Hi, thanks for the issue and PR. When you say:

It would be as simple as modifying the template file that includes that snippet.

This is true, and there is already a mechanism for doing this using the -user_templates option. Basically I'm trying to push back on this just a little so we don't go on accumulating options forever.

So, is there a reason this solution is better for you than -user_templates, or could we maybe make it more generic by making it act on any template name by making it a null operation that just returns an empty string?

@ktsuench
Copy link
Author

I think that's a good point. I could take a look into making it act on any template name to exclude templates during the transformation process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants