Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SafariViewController instead of WebView #129

Open
alexkaessner opened this issue Jul 28, 2016 · 2 comments
Open

Use SafariViewController instead of WebView #129

alexkaessner opened this issue Jul 28, 2016 · 2 comments

Comments

@alexkaessner
Copy link

Would be nice to use the iOS 9 SafariViewController instead of the WebView to benefit from the new features of it. At least a small option to use it would be great.

PS: Is the app still maintained? We've seen no commit for a long time.

@avihard
Copy link

avihard commented Feb 11, 2019

I appreciate your question but i'm thinking that it is not good to see a webView just because of it is application so safari browser seems awkward.

@alexkaessner
Copy link
Author

@avikorat Beside the fact that the app isn't even available anymore, I'm not sure if I understand your answer right.

Most apps use a SFSafariViewController these days to present web content. This brings a lot of advantages over the custom WKWebView. As Apple also says:

If your app lets users view websites from anywhere on the Internet, use the SFSafariViewController class. If your app customizes, interacts with, or controls the display of web content, use the WKWebView class.

The DesignerNewsApp just displayed websites and did not customize the contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants