Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After returning to the app, the app briefly swiches to light theme #754

Closed
pbocek opened this issue Jul 18, 2023 · 14 comments · Fixed by #802
Closed

After returning to the app, the app briefly swiches to light theme #754

pbocek opened this issue Jul 18, 2023 · 14 comments · Fixed by #802
Assignees
Labels
bug Something isn't working or working properly medium priority should be completed when there is time visual strictly based around visual (ui, graphics, etc), ie no functionality

Comments

@pbocek
Copy link
Contributor

pbocek commented Jul 18, 2023

Describe the bug
After returning to the app, the app briefly swiches to light theme. Seems to me like it happens everytime, after waking it from sleep. Doesn't happend if the app starts again.

To Reproduce
Steps to reproduce the behavior:

  1. Open app
  2. Go to desktop
  3. Reopen the app
  4. Wait few seconds

Expected behavior
I would expect, that it does not switch theme.

Screenshots
https://github.com/Memmy-App/memmy/assets/19386789/db8b8fe7-52f5-4023-a8c9-5e6710b4a59e

Smartphone (please complete the following information):

  • Device: iPhone 13 Mini
  • OS: iOS
  • Version 16.5.1(c)
@pbocek pbocek added the bug Something isn't working or working properly label Jul 18, 2023
@eoddc5
Copy link
Contributor

eoddc5 commented Jul 18, 2023

I have never seen this nor can I get this to reproduce

@gkasdorf or @sgriff96 either of you have any ideas?

@Semmelstulle
Copy link

This also happens for me when closing out of the image viewer sometimes.
• iPhone SE 2020
• iOS
• iOS 16.5.1(c)

@Taxxor90
Copy link

Taxxor90 commented Jul 18, 2023

Can also confirm
iPhone 12 Pro
iOS 16.5.1(c)
App version 0.4(2)

It only happens when I set it to use light/dark according to your system setting.
Played around with it a bit and for me, it's resuming in the set dark theme, then after a second it's switching to whatever you've set as the light theme for a second before going back to the dark theme.
This happens pretty consistently on almost every resume of the app, like in 8/10 cases

@edcabreraf
Copy link

This also happens to me, dark theme to light theme and then back to dark theme, or light theme to dark theme and then back to light theme.

iPhone 13
iOS 16.5.1 (c)
App version 0.4 (2)

@eoddc5 eoddc5 added medium priority should be completed when there is time visual strictly based around visual (ui, graphics, etc), ie no functionality labels Jul 18, 2023
@theycallmebeez
Copy link

Cannot reproduce. Using iOS 17 on iPhone 13. Latest app update 0.4 (2)

@jderose9
Copy link
Contributor

Seems to be a regression in .4. Only happens when the app restarts after iOS has unloaded it from ram, not just put briefly in background.

@sgriff96
Copy link
Collaborator

I assume it's some logic with the match system theme that's causing issues with this

@jderose9
Copy link
Contributor

I’m guessing it’s related to the react native update. There’s a couple similar issues open on their repo, though they pre-date the current release. Still, maybe one of the workarounds described there could take care of it.

facebook/react-native#35972

facebook/react-native#36713

@englut
Copy link

englut commented Jul 21, 2023

Getting same issue with latest 0.5 (3). Glitches to dark theme and back for me.

@gkasdorf
Copy link
Collaborator

Let's see if I can fix this.

@gkasdorf gkasdorf self-assigned this Jul 22, 2023
@gkasdorf
Copy link
Collaborator

Fixed! Not sure how this ever worked correctly but anyway 🤷

@gkasdorf gkasdorf linked a pull request Jul 22, 2023 that will close this issue
@gkasdorf
Copy link
Collaborator

gkasdorf commented Jul 22, 2023

Ah, ok. There is an open issue with React Native about this like @jderose9 mentioned. facebook/react-native#35972

For now I've implemented a hack mentioned in that issue for this. Will re-visit at a later time.

@TheFunkyMonk
Copy link

This is still happening to me. Usually when I open the app, and it does seem to only be tied to the “match system theme” option.

iPhone 14 Pro
iOS 16.15.1(c)
Memmy 0.4 (2)

@gkasdorf
Copy link
Collaborator

It's fixed now, but Apple has not approved the updated build yet for the App Store. @TheFunkyMonk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or working properly medium priority should be completed when there is time visual strictly based around visual (ui, graphics, etc), ie no functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.