From 9ea9cf20354302f7cd49643746aa5c8b240c7e1e Mon Sep 17 00:00:00 2001 From: Mladen Macanovic Date: Thu, 25 Nov 2021 11:11:03 +0100 Subject: [PATCH 1/4] Mark snackbarInfos as readonly --- Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs b/Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs index 11250f2598..cd3fd03ed1 100644 --- a/Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs +++ b/Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs @@ -72,7 +72,7 @@ public SnackbarInfo( MarkupString message, private SnackbarStackLocation location = SnackbarStackLocation.Center; - private List snackbarInfos = new(); + private readonly List snackbarInfos = new(); #endregion From 8536eee70f58599798bc8a2b5df034dc568e80ec Mon Sep 17 00:00:00 2001 From: Mladen Macanovic Date: Thu, 25 Nov 2021 11:11:20 +0100 Subject: [PATCH 2/4] Fix unused snackbar title parameter --- Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs b/Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs index cd3fd03ed1..a9fbabbe21 100644 --- a/Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs +++ b/Source/Extensions/Blazorise.Snackbar/SnackbarStack.razor.cs @@ -120,7 +120,7 @@ public Task PushAsync( MarkupString message, SnackbarColor color = SnackbarColor /// Returns awaitable task. public Task PushAsync( string message, string title = null, SnackbarColor color = SnackbarColor.None, Action options = null ) { - return PushAsync( (MarkupString)message, null, color, options ); + return PushAsync( (MarkupString)message, title, color, options ); } /// From 9431e83b9c2038fe7228c061972174d5bbb240fd Mon Sep 17 00:00:00 2001 From: Mladen Macanovic Date: Thu, 25 Nov 2021 11:11:41 +0100 Subject: [PATCH 3/4] Override ReleaseResources --- Source/Blazorise/Base/BaseTextInput.razor.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Source/Blazorise/Base/BaseTextInput.razor.cs b/Source/Blazorise/Base/BaseTextInput.razor.cs index 439d3234fe..d94e52962f 100644 --- a/Source/Blazorise/Base/BaseTextInput.razor.cs +++ b/Source/Blazorise/Base/BaseTextInput.razor.cs @@ -54,19 +54,22 @@ protected override ValueTask DisposeAsync( bool disposing ) { ReleaseResources(); } + return base.DisposeAsync( disposing ); } /// /// Shared code to dispose of any internal resources. /// - protected virtual void ReleaseResources() + protected override void ReleaseResources() { if ( inputValueDebouncer != null ) { inputValueDebouncer.Debounced -= OnInputValueDebounced; inputValueDebouncer = null; } + + base.ReleaseResources(); } /// From 1589fc3983270b61cf1f6055d754ee3cbbb9b1ee Mon Sep 17 00:00:00 2001 From: Mladen Macanovic Date: Thu, 25 Nov 2021 11:11:54 +0100 Subject: [PATCH 4/4] Fix missing comment param --- Source/Blazorise/Themes/ThemeGenerator.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/Source/Blazorise/Themes/ThemeGenerator.cs b/Source/Blazorise/Themes/ThemeGenerator.cs index e27d4b216b..b43347781f 100644 --- a/Source/Blazorise/Themes/ThemeGenerator.cs +++ b/Source/Blazorise/Themes/ThemeGenerator.cs @@ -361,6 +361,7 @@ protected virtual void GenerateSidebarVariables( Theme theme, ThemeSidebarOption /// /// Generates the bar component CSS variables. /// + /// Currently used theme options. /// Bar options. protected virtual void GenerateBarVariables( Theme theme, ThemeBarOptions barOptions ) {