Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Markdown editor table icon takes the whole row #5876

Closed
JanVargovsky opened this issue Dec 3, 2024 · 3 comments
Closed

[Bug]: Markdown editor table icon takes the whole row #5876

JanVargovsky opened this issue Dec 3, 2024 · 3 comments
Assignees
Labels
Type: Bug 🐞 Something isn't working
Milestone

Comments

@JanVargovsky
Copy link

Blazorise Version

1.7.0

What Blazorise provider are you running on?

None

Link to minimal reproduction or a simple code snippet

The Markdown component has a menu (icons/buttons) on the top. One specific table button has the class "table" and takes the row component.

Current look:
Image

Old look with 1.6.2 version:
Image

Affected providers:
Bootstrap 4 - https://bootstrapdemo.blazorise.com/tests/markdown
Bootstrap 5 - https://bootstrapdemo.blazorise.com/tests/markdown
Material - https://materialdemo.blazorise.com/tests/markdown

Steps to reproduce & bug description

Use Markdown component with table

What is expected?

The table icon/button looks the same as the other icons/buttons

What is actually happening?

The table icon/button takes the whole row

What browsers do you see the problem on?

Chrome, Microsoft Edge

Any additional comments?

No response

@JanVargovsky JanVargovsky added the Type: Bug 🐞 Something isn't working label Dec 3, 2024
@stsrki
Copy link
Collaborator

stsrki commented Dec 3, 2024

It seems the problem is in how the button class is named. It is defined as a table, which is basically using the Bootstrap default table class.

The solution might be to use prefixes for toolbar buttons.

Not for self: use toolbarButtonClassPrefix on https://github.com/Ionaru/easy-markdown-editor

@stsrki stsrki self-assigned this Dec 3, 2024
@stsrki stsrki added this to Support Dec 3, 2024
@github-project-automation github-project-automation bot moved this to 🔙 Backlog in Support Dec 3, 2024
@stsrki stsrki added this to the 1.7 support milestone Dec 3, 2024
@linkdotnet
Copy link

linkdotnet commented Dec 4, 2024

Setting ToolbarButtonClassPrefix="mde" also doesn't seem to help.

The problem with table button and the .table class is that it is defined in bootstrap leading to the shown issue.

@stsrki
Copy link
Collaborator

stsrki commented Dec 4, 2024

Setting ToolbarButtonClassPrefix="mde" also doesn't seem to help.

The problem with table button and the .table class is that it is defined in bootstrap leading to the shown issue.

It's because ToolbarButtonClassPrefix isn't passed down to the JS. We need to fix it for 1.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Status: ✔ Done
Development

No branches or pull requests

3 participants