Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] DataGrid: Change TotalItems from int to long #5170

Open
stsrki opened this issue Dec 2, 2023 · 3 comments
Open

[2.0] DataGrid: Change TotalItems from int to long #5170

stsrki opened this issue Dec 2, 2023 · 3 comments
Assignees
Labels
Type: Feature ⚙ Request or idea for a new feature.
Milestone

Comments

@stsrki
Copy link
Collaborator

stsrki commented Dec 2, 2023

Current

[Parameter] public int? TotalItems { get => paginationContext.TotalItems; set => paginationContext.TotalItems = value; }

New

[Parameter] public long? TotalItems { get => paginationContext.TotalItems; set => paginationContext.TotalItems = value; }


Also see if other components need the same API change.

@stsrki stsrki added the Type: Feature ⚙ Request or idea for a new feature. label Dec 2, 2023
@stsrki stsrki added this to the 2.0 milestone Dec 2, 2023
@stsrki stsrki changed the title DataGrid: Change TotalItems from int to long [.0] DataGrid: Change TotalItems from int to long Jul 30, 2024
@stsrki stsrki changed the title [.0] DataGrid: Change TotalItems from int to long [2.0] DataGrid: Change TotalItems from int to long Jul 30, 2024
@github-project-automation github-project-automation bot moved this to No Status in Development Dec 2, 2024
@tesar-tech
Copy link
Collaborator

What do you mean by "components need the same API change"? I understand that related properties should be also long, but do you want to also change similar properties in other "listable" components?

What is even motivation behind this change? Is it just the need to suport more then int.MaxValue rows/items?

@stsrki
Copy link
Collaborator Author

stsrki commented Dec 12, 2024

I probably meant to check some other component that has a similar API, with TotalItems. The Autocomplete comes to mind.

@stsrki
Copy link
Collaborator Author

stsrki commented Dec 12, 2024

What is even motivation behind this change? Is it just the need to suport more then int.MaxValue rows/items?

To support larger datasets. Some organizations could have billions of data, and int could not support it. This change should not be much of a breaking change, and the benefits are many.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature ⚙ Request or idea for a new feature.
Projects
Status: No Status
Development

No branches or pull requests

2 participants