Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarDropdownToggle Clicked event does not fire #4707

Closed
ivancavlek opened this issue Mar 30, 2023 · 10 comments
Closed

BarDropdownToggle Clicked event does not fire #4707

ivancavlek opened this issue Mar 30, 2023 · 10 comments
Assignees
Labels
Type: Bug 🐞 Something isn't working
Milestone

Comments

@ivancavlek
Copy link

Describe the bug
BarDropdownToggle Clicked event does not fire. After clicking the toggle for BarDropdownToggle, nothing happens. This is not the case with other toggles.

To Reproduce

@inherits LayoutComponentBase

<Layout>
    <LayoutHeader>
        <Bar Background="Background.Primary"
                Breakpoint="Breakpoint.Desktop"
                ThemeContrast="ThemeContrast.Light">
            <BarToggler />
            <BarMenu>
                <BarStart>
                    <BarItem>
                        <BarDropdown>
                            <BarDropdownToggle Clicked="OnLoadAppLinks">
                            </BarDropdownToggle>
                            <BarDropdownMenu>
                            </BarDropdownMenu>
                        </BarDropdown>
                    </BarItem>
                </BarStart>
            </BarMenu>
        </Bar>
    </LayoutHeader>
    <LayoutContent Margin="Margin.Is5.FromTop.Is5.FromBottom">
        <CascadingValue IsFixed="true"
                        Value="this">
            <LoadingIndicator FullScreen="true">
                @Body
            </LoadingIndicator>
        </CascadingValue>
    </LayoutContent>
</Layout>

@code
{
    private void OnLoadAppLinks() =>
        Console.WriteLine("Entered");
}
@ivancavlek ivancavlek added the Type: Bug 🐞 Something isn't working label Mar 30, 2023
@stsrki stsrki added this to the 1.2 support milestone Mar 30, 2023
@stsrki
Copy link
Collaborator

stsrki commented Mar 30, 2023

This might be because if the changes we have made in the last release. @David-Moreira can you look into this?

@David-Moreira
Copy link
Contributor

David-Moreira commented Mar 31, 2023

Hey @stsrki
For a moment I thought the same, but apparently is due to this:
EDIT(With dates):
image

If a ParentDropdown exists the Clicked isn't triggered. What do you think? I believe we should still trigger it.

@David-Moreira
Copy link
Contributor

Also the recent changes were #4655 which is BarToggler, not BarDropdownToggler.

@stsrki
Copy link
Collaborator

stsrki commented Mar 31, 2023

I believe we should still trigger it.

Yes, the click should still be triggered.

@devantler
Copy link

Any chance that you can make a prerelease for this fix? 🙏🏻

@stsrki
Copy link
Collaborator

stsrki commented Apr 2, 2023

Any chance that you can make a prerelease for this fix? 🙏🏻

Can't promise but I will try to make it.

@devantler
Copy link

Any chance that you can make a prerelease for this fix? 🙏🏻

Can't promise but I will try to make it.

Fair enough! And thanks

@devantler
Copy link

I understand if it is not a priority to do a pre-release just for this issue, but do you know when we can expect a new release that includes this fix?

@stsrki
Copy link
Collaborator

stsrki commented Apr 21, 2023

We plan to release it next week.

@devantler
Copy link

Thanks, that is awesome news!

@stsrki stsrki added this to Support Aug 3, 2024
@stsrki stsrki moved this to ✔ Done in Support Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants