Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check inside Dropdown doesn't work anymore #3171

Closed
ivancavlek opened this issue Nov 25, 2021 · 2 comments
Closed

Check inside Dropdown doesn't work anymore #3171

ivancavlek opened this issue Nov 25, 2021 · 2 comments
Labels
Type: Bug 🐞 Something isn't working

Comments

@ivancavlek
Copy link

ivancavlek commented Nov 25, 2021

Describe the bug
I have a Check inside Dropdown.
Prior to v0.9.5 it worked perfectly!
After I've updated to v0.9.5 it doesn't work anymore. Check can't be checked or unchecked anymore.

To Reproduce
This is a basic example to reproduce the bug:

<Dropdown>
    <DropdownToggle Color="Color.Info">
        Test
    </DropdownToggle>
    <DropdownMenu>
        <DropdownItem Flex="Flex.JustifyContent.Between.AlignItems.Center">
            <Check TValue="bool"
                   @bind-Checked="_isFilterVisible">
                Bla
            </Check>
        </DropdownItem>
    </DropdownMenu>
</Dropdown>

@code{
    bool _isFilterVisible;
}
@stsrki
Copy link
Collaborator

stsrki commented Nov 25, 2021

I can confirm on our side, thank you for the code sample.

@David-Moreira I found this is happening because we have added @onclick:preventDefault @onclick:stopPropagation on DropdownItem. If I remove it, it seems to be working fine without. Do you remember why we needed it?

@stsrki stsrki added the Type: Bug 🐞 Something isn't working label Nov 25, 2021
@stsrki stsrki added this to the 0.9.5 Support milestone Nov 25, 2021
@David-Moreira
Copy link
Contributor

Well apparently I added it on
Nested dropdowns and refactor of closeable components #2954 #2ada4dbcfe5d4d9a73370be476feca4a38a9e52c

Maybe on the first version I was doing it made sense... I did remove it also, seems fine on all providers. I guess we should remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants