You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While trying to set a grid so that a column was sorted by default I reasoned that the property would be on a column somewhere, but typing "Sort" in to see what intellisense would suggest brought only "Sortable" and "SortDirectionTemplate".
The property Direction is what I required, but I think it would be helpful to [Obsolete] this for a few releases and provide a mirrored property named SortDirection that does the same thing, before eventually removing Direction entirely.
It would establish consistency of naming with the property type (enum Blazorise.SortDirection) and other how other properties are named (e.g. public Blazorise.TextAlignment TextAlignment uses a property named the same as the enum) and also related props like SortDirectionTemplate. It would also result in putting sorting related properties together in Intellisense
I realize it's a breaking change, but looks like a simple enough one that the Obsolete mechanism can easily handle it
The text was updated successfully, but these errors were encountered:
Op said it all. Whenever you can have the functionality name as prefix or part of the name, great!
Datagrid has a freaking lot parameters so it helps with searching them by name and quickly correctly associate it with what it does. I remember this also happened to me when searching for some parameter, I don't recall if it was direction.
In my opinion, we should not bother with obsolete on a simple parameter...
While trying to set a grid so that a column was sorted by default I reasoned that the property would be on a column somewhere, but typing "Sort" in to see what intellisense would suggest brought only "Sortable" and "SortDirectionTemplate".
The property
Direction
is what I required, but I think it would be helpful to[Obsolete]
this for a few releases and provide a mirrored property namedSortDirection
that does the same thing, before eventually removingDirection
entirely.It would establish consistency of naming with the property type (
enum Blazorise.SortDirection
) and other how other properties are named (e.g.public Blazorise.TextAlignment TextAlignment
uses a property named the same as the enum) and also related props likeSortDirectionTemplate
. It would also result in putting sorting related properties together in IntellisenseI realize it's a breaking change, but looks like a simple enough one that the Obsolete mechanism can easily handle it
The text was updated successfully, but these errors were encountered: