Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal Title HeadingSize #2232

Closed
EnsignPayton opened this issue Apr 23, 2021 · 1 comment
Closed

Modal Title HeadingSize #2232

EnsignPayton opened this issue Apr 23, 2021 · 1 comment
Labels
Type: Feature ⚙ Request or idea for a new feature.
Milestone
0.9.4

Comments

@EnsignPayton
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Minor one, but I'd like to specify the heading size for a ModalTitle. It's currently hard-coded to h4.

Describe the solution you'd like

I can easily replace my ModalTitle with a plain Heading and add the class myself, but it would be slightly more convenient to have a Size property exposed directly on the ModalTitle with it using Heading internally.

@* <ModalTitle>@Title</ModalTitle> *@
<Heading Size="HeadingSize.Is5" Class="modal-title">@Title</Heading>
@stsrki
Copy link
Collaborator

stsrki commented Apr 23, 2021

Makes sense. It is an easy fix.

@stsrki stsrki added the Type: Feature ⚙ Request or idea for a new feature. label Apr 23, 2021
@stsrki stsrki added this to the 0.9.4 milestone Apr 23, 2021
This was referenced Apr 26, 2021
Merged
Closed
@stsrki stsrki closed this as completed Apr 26, 2021
@stsrki stsrki moved this to ✔ Done in Development Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature ⚙ Request or idea for a new feature.
Projects
Development
Archived in project
Milestone
0.9.4
Development

No branches or pull requests
2 participants
@stsrki @EnsignPayton