Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating Components #1996

Closed
andreatosato opened this issue Mar 9, 2021 · 9 comments
Closed

Rating Components #1996

andreatosato opened this issue Mar 9, 2021 · 9 comments
Labels
Type: Feature ⚙ Request or idea for a new feature.
Milestone

Comments

@andreatosato
Copy link
Contributor

Hi blazorise team,
I have created Rating component, but I need to color Icon.
Can I color Icon?
My component code

Preview
2021-03-09_21h52_46

I think that this component is basic and can it add in blazorise library. What do you think?

@stsrki
Copy link
Collaborator

stsrki commented Mar 10, 2021

It looks good. I also started work on a rating component but didn't finish it yet. Your seems to have more features. If you want you can create a PR and I can see into it.

@andreatosato
Copy link
Contributor Author

Can I add pull request to new branch?
I create this commit in my github repo

@stsrki
Copy link
Collaborator

stsrki commented Mar 10, 2021

@stsrki
Copy link
Collaborator

stsrki commented Mar 10, 2021

I think its best to make it part of Blazorise.Components project

@andreatosato
Copy link
Contributor Author

I want to create branch feature... dev094-rating.
How can I create new branch?

@stsrki
Copy link
Collaborator

stsrki commented Mar 11, 2021

You checkout(switch) to dev094 branch, and then create new branch from it, Everything can be done in VS.

image

@andreatosato
Copy link
Contributor Author

No, I want to create new branch on my pull request.
I create this pull #2017 on dev094 branch.

@WillianGruber
Copy link
Contributor

Why don't you accept the values of the icons as string, so we can pass our own icons? Something like emptyItemIcon and filledItemIcon? I would have an use for this. Of course, the default could be filled and empty stars.

@andreatosato
Copy link
Contributor Author

andreatosato commented Mar 12, 2021

@WillianGruber
I accept:

[Parameter] public string FullIcon { get; set; }
[Parameter] public string EmptyIcon { get; set; }

But i think that I need to accept also

[Parameter] public string FullIconStyle { get; set; }
[Parameter] public string EmptyIconStyle { get; set; }

So I can manage FontAwesome or Material

@stsrki stsrki mentioned this issue Mar 23, 2021
@stsrki stsrki added the Type: Feature ⚙ Request or idea for a new feature. label Mar 23, 2021
@stsrki stsrki added this to the 0.9.4 milestone Mar 23, 2021
@stsrki stsrki closed this as completed Mar 23, 2021
@stsrki stsrki moved this to ✔ Done in Development Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature ⚙ Request or idea for a new feature.
Projects
Archived in project
Development

No branches or pull requests

3 participants