Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Tech crew names in hangar not cut by elipses #2707

Closed
JonhyBurner opened this issue Jun 20, 2021 · 5 comments · Fixed by #2712
Closed

[UI] Tech crew names in hangar not cut by elipses #2707

JonhyBurner opened this issue Jun 20, 2021 · 5 comments · Fixed by #2712
Assignees

Comments

@JonhyBurner
Copy link

MekHQ 49.2
OpenJDK 11

Not sure when it started, but in the hangar tab, too large tech crew names no longer get cut with elipses. Instead they get two lines for their names, which results in visual oddites.

MechTech name borked

MechTech name even more borked

I don't think files are needed, to reproduce, just reduce the size of the tech crew column.

@sixlettervariables sixlettervariables added Bug Needs Investigation This issue needs investigation and/or triage. labels Jun 20, 2021
@sixlettervariables
Copy link
Contributor

sixlettervariables commented Jun 21, 2021

I don't believe this has anything to do with the length of their names (the HTML logic for the Force column is the same as the Tech Crew column). I get those visual oddities with just short names too.

I believe this is a rendering bug...though I'm not certain what we can do.

@sixlettervariables sixlettervariables added Help Wanted The Core developers are unlikely to work on this and are open to community help and removed Needs Investigation This issue needs investigation and/or triage. labels Jun 21, 2021
@Windchild292
Copy link
Contributor

The problem appears to be because it uses HTML as part of the backend sorting.

@sixlettervariables
Copy link
Contributor

I've only seen this once we went to Java 11 if that helps narrow it down any.

@Windchild292
Copy link
Contributor

It occurred as part of my sorting improvements, definitely relating to the HTML

@Windchild292 Windchild292 self-assigned this Jun 21, 2021
@Windchild292 Windchild292 added GUI and removed Help Wanted The Core developers are unlikely to work on this and are open to community help labels Jun 21, 2021
@Windchild292
Copy link
Contributor

The ellipses isn't possible due to the age of Swing, which uses HTML 3.2. Ellipses functionality was added around HTML 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants